Skip to content

Add to the list of drawbacks for mixins #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

skirtles-code
Copy link
Contributor

I've changed the heading for the final section from Precautions to Drawbacks. I think that's a more accurate reflection of what's in that section.

For the first item in the list I've changed the word 'feature' to 'mixin'. Nowhere else on this page refers to mixins as features.

I've added a middle item to the list that discusses the problem of figuring out where properties come from when using mixins. That seems worthy of a separate point to me, though it does overlap a little with the previous item. I've removed the words 'and for debugging' from that first item as I think this is what it was alluding to.

For the final item I've just changed the punctuation.

@NataliaTepluhina NataliaTepluhina merged commit f0cfcb0 into vuejs:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants